In success case, CGI scripts should return 0, not 1.#152
Merged
httpdss merged 1 commit intohttpdss:masterfrom Dec 11, 2025
Merged
In success case, CGI scripts should return 0, not 1.#152httpdss merged 1 commit intohttpdss:masterfrom
httpdss merged 1 commit intohttpdss:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect exit codes in three CGI script functions. The functions were returning 1 (indicating error) in success cases, which caused spurious error log messages when using the Python server.
Key Changes:
- Changed return values from 1 to 0 for successful execution in CGI handler functions
- Affects three JSON response functions:
list_hosts_json,action_show_host_json, andaction_show_plugin_json
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When running the included Python server for collectd-web, there are lots of errors like this in the log (i.e. on stdout);
127.0.0.1 - - [06/Dec/2025 22:02:29] CGI script exit code 1
These are not needed or wanted, since in all three cases the code was executed successfully.
Description
Make the CGI script return 0 instead of 1, which is interpreted as an error.
Checklist
Yes - and noticed that the link is broken and should be https://github.com/httpdss/collectd-web/blob/master/.github/CONTRIBUTING.md instead.
Screenshots (if applicable)
Additional Comments