Add an option to hide or show Cache and Buffers in Graph mode#1540
Add an option to hide or show Cache and Buffers in Graph mode#1540fasterit merged 4 commits intohtop-dev:mainfrom
Conversation
|
The actual change looks good (should be one commit though, not two), but I'm not very eager about the feature overall. @fasterit @natoscott What do you think? |
|
I think for consistency reasons this switch should also affect the bar mode. |
fasterit
left a comment
There was a problem hiding this comment.
As I said on a comment this should also affect bar mode.
The cheap "NaN" stunt causes an assert failure:
stderr output >>>>>>>>>>
htop: Meter.c:409: Meter_humanUnit: Assertion `value >= 0.0' failed.
<<<<<<<<<< stderr output <<<<<<<<<<
The code also needs to save the setting to htoprc and print it in the crash handler (the Settings handling is incomplete).
I don't love it, as it adds yet another configurable option many people wont need and the Options menu is already cluttered. OTOH I don't see any better solution, so I wont object to it being added. |
|
@fasterit Merged too fast. I think some of the commits should have been squashed before merging. Otherwise we would have small fixup commits forever in the history of |
|
I cleaned up the history (squashing the merge + amended commit). AFAICS only one fork (that I follow/fetch) pulled that commit by the time I force-pushed the updated tip. |
This PR covers issue #407.
Added this option to "Display Options". It's enabled by default to be compatible with current behavior. Disabling it will remove Cache and Buffers memory from Memory Graph and Mem&Swp Graph.