Ros_launch.sh and example#45
Merged
elandini84 merged 1 commit intohsp-iit:ironfrom Jan 25, 2024
Merged
Conversation
|
Hi @fbrand-new, this pull request fixes the SIGTERM handling issue ros2/launch#712. We use it internally with systemd and Podman containers as they send SIGTERM and not SIGINT (what ROS Launch expects) by default as part of the shutdown process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept for a workaround that allows the user to run ros2 launch files from yarpmanager and correctly stop the nodes managed by the launch file.
Currently
ros2 launchis not stopped correctly by a SIGTERM signal (ros2/launch#666) which leaves the underline nodes dangling. Unfortunately for us this is exactly what happens under the hood when we stop from yarpmanager.Of the many possible workaround to fix this behaviour I propose this one since it allows us to modify the applications that need it once for all and we don't have to worry about it at runtime nor we risk introducing regressions in yarprun.
I am also leaving an example attached. I am open to discuss if it would be worth to transform this in a piece of software more structured than this - admittedly rough - bash script