Skip to content

[Quest Sample] Add advanced Copilot data agent content#13

Open
github-actions[bot] wants to merge 1 commit intomainfrom
quest-sample-pr-20251204-153914
Open

[Quest Sample] Add advanced Copilot data agent content#13
github-actions[bot] wants to merge 1 commit intomainfrom
quest-sample-pr-20251204-153914

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions bot commented Dec 4, 2025

Description

This PR adds comprehensive content to the implement-fabric-data-agents module, addressing learner feedback for more practical guidance on enterprise implementations.

Changes Made

New Content Files

File Description
copilot-advanced-scenarios.md Multi-turn conversations, cross-source correlation, automated insights
copilot-best-practices.md Data preparation, security config, performance optimization
copilot-troubleshooting.md Common issues, error codes, diagnostic steps

Modified Files

File Changes
index.yml Added three new units to module structure

Content Review Checklist

  • Technical accuracy verified against current Fabric capabilities
  • Code samples tested in Fabric workspace
  • Screenshots captured from current UI (November 2024)
  • Accessibility: All images have descriptive alt text
  • Terminology review: Consistent "Copilot for Microsoft Fabric" usage
  • Link validation: All xrefs and external links verified
  • Spell check completed

Module Impact

  • Current units: 7
  • After merge: 10 (3 new units added)
  • Estimated completion time change: +15 minutes

Related Issues

  • Addresses feedback from Issue #45: "Need more troubleshooting guidance"
  • Partial fix for Issue #38: "Enterprise scenarios not covered"

⚠️ This is a sample PR for Quest Scenario 2

This PR intentionally includes issues for review practice:

YAML Issues:

  • Missing colon after prerequisites in index.yml (line 20)
  • Outdated ms.date: 04/15/2024

Content Issues:

  • Typos: "avialable", "setings", "Intermitent", "occured"
  • Broken link: http://old-support.fabric.com/help
  • Inconsistent terminology: Mix of "Copilot" and "data agents"

Structural Issues:

  • Code sample uses deprecated fabric.dataagent import path
  • Missing > [!IMPORTANT] callout for security section

Use GitHub Copilot to:

  1. Review the PR with @workspace
  2. Identify content and technical issues
  3. Validate YAML structure
  4. Generate constructive feedback for the author

This is a sample PR for Quest Scenario 2. Part of GitHub Copilot Repository Management Quest for Microsoft Learn content.

This PR adds comprehensive content to the implement-fabric-data-agents module:

New content:
- Advanced scenarios unit (multi-turn, cross-source, auto-insights)
- Best practices unit (data prep, security, performance)
- Troubleshooting unit (common issues and solutions)
- Updated index.yml with new units

Addresses learner feedback requesting more practical guidance for
enterprise data agent implementations.

Related to content refresh initiative for Fabric Copilot modules.

This comment was marked as duplicate.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

## Security configuration

Configure appropriate security boundaries for your data agents:

Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security configuration section discusses sensitive data handling and security boundaries but lacks an IMPORTANT callout to emphasize its critical nature. According to the PR description, security sections should include a callout to highlight their importance to readers.

Suggested change
> [!IMPORTANT]
> Misconfigured security boundaries can expose sensitive data through Copilot responses. Always validate row-level security, workspace roles, and audit logging in non-production environments before rolling changes into production.

Copilot uses AI. Check for mistakes.
Comment on lines +23 to +31
```python
# Example: Agent correlating customer data across sources
from fabric.dataagent import DataAgent

agent = DataAgent(workspace="sales-analytics")
response = agent.query(
"Compare customer satisfaction scores with purchase frequency"
)
```
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code block is missing a language specifier. According to Microsoft Learn guidelines, all code blocks should specify the language. This should be marked as "python" to enable proper syntax highlighting.

Copilot generated this review using guidance from repository custom instructions.
3. Sample query that reproduces the issue
4. Timestamp of when the issue occured

Contact support at [Fabric Support](http://old-support.fabric.com/help).
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The support link appears to be using an outdated or placeholder URL (old-support.fabric.com). Please update this to the current official Microsoft Fabric support URL to ensure users can access help resources.

Copilot uses AI. Check for mistakes.
metadata:
title: Implement Fabric data agents
description: Learn how to implement and manage data agents in Microsoft Fabric for enhanced data interaction.
ms.date: 04/15/2024
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ms.date value is outdated (April 15, 2024). According to Microsoft Learn guidelines, ms.date values should be within the last 12 months. Please update this to a more recent date.

Copilot generated this review using guidance from repository custom instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant