fix: update free text validation regex handling#795
Open
ibrahimozkn wants to merge 5 commits intodevfrom
Open
Conversation
johannesvedder
requested changes
Feb 25, 2026
johannesvedder
requested changes
Feb 25, 2026
designer_v2/lib/features/design/shared/questionnaire/question/question_form_controller.dart
Show resolved
Hide resolved
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 23178981 | Triggered | JSON Web Token | 8003bb5 | flutter_common/lib/envs/.env.dev | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Visit the preview URL for this PR (updated for commit df995b5):
(expires Sun, 08 Mar 2026 11:26:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request improves the validation and user experience for custom free-text questions by simplifying error messages, ensuring consistent regex validation, and refactoring related code in both the app and the designer. The changes focus on making custom input validation more robust and user-friendly, especially for fields requiring custom regular expressions.
Localization and Error Message Simplification:
free_text_custom_errorlocalization in both English and German to a simpler, more general message, and removed the{pattern}placeholder from all relevant files (app_en.arb,app_de.arb,app_localizations.dart,app_localizations_en.dart,app_localizations_de.dart). [1] [2] [3] [4] [5]App-Side Free-Text Validation Refactor:
free_text_question_widget.dartto use a new helper (free_text_regex_validation.dart) for building and validating full-match regex patterns, and to use the simplified error message when validation fails. [1] [2] [3] [4]Designer-Side Regex Validation Improvements:
QuestionFormViewModelin the designer to validate custom regex expressions more robustly, ensuring invalid patterns are caught early, and to update related controls when the free-text type changes. [1] [2] [3]