Skip to content

fix: update free text validation regex handling#795

Open
ibrahimozkn wants to merge 5 commits intodevfrom
fix/freetextfield-validation
Open

fix: update free text validation regex handling#795
ibrahimozkn wants to merge 5 commits intodevfrom
fix/freetextfield-validation

Conversation

@ibrahimozkn
Copy link
Contributor

This pull request improves the validation and user experience for custom free-text questions by simplifying error messages, ensuring consistent regex validation, and refactoring related code in both the app and the designer. The changes focus on making custom input validation more robust and user-friendly, especially for fields requiring custom regular expressions.

Localization and Error Message Simplification:

  • Changed the free_text_custom_error localization in both English and German to a simpler, more general message, and removed the {pattern} placeholder from all relevant files (app_en.arb, app_de.arb, app_localizations.dart, app_localizations_en.dart, app_localizations_de.dart). [1] [2] [3] [4] [5]

App-Side Free-Text Validation Refactor:

  • Updated the validation logic in free_text_question_widget.dart to use a new helper (free_text_regex_validation.dart) for building and validating full-match regex patterns, and to use the simplified error message when validation fails. [1] [2] [3] [4]

Designer-Side Regex Validation Improvements:

  • Enhanced the QuestionFormViewModel in the designer to validate custom regex expressions more robustly, ensuring invalid patterns are caught early, and to update related controls when the free-text type changes. [1] [2] [3]
  • Updated the free-text question form view to display appropriate validation messages for required fields and invalid patterns.

Copy link
Contributor

@johannesvedder johannesvedder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Complete is still possible ven though text is not in required format. Is this fixable?
Image

@gitguardian
Copy link

gitguardian bot commented Mar 1, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
23178981 Triggered JSON Web Token 8003bb5 flutter_common/lib/envs/.env.dev View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Visit the preview URL for this PR (updated for commit df995b5):

(expires Sun, 08 Mar 2026 11:26:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants