Skip to content

chore: update vitejs/plugin-legacy version#105

Merged
laurynasgadl merged 1 commit into
masterfrom
chore/update-vitejs/plugin-legacy
Jun 8, 2026
Merged

chore: update vitejs/plugin-legacy version#105
laurynasgadl merged 1 commit into
masterfrom
chore/update-vitejs/plugin-legacy

Conversation

@laurynasgadl

@laurynasgadl laurynasgadl commented Jun 8, 2026

Copy link
Copy Markdown
Member

https://github.com/hostinger/filebrowser/security/dependabot/206

Summary by CodeRabbit

  • Bug Fixes

    • Fixed catch-all routing so unknown or empty paths correctly redirect to the files landing page, and valid path segments are preserved when navigating.
  • Chores

    • Updated a build-related dev dependency to the latest patch version.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1dbf17c1-dae2-4188-a76b-0f0f8e10af3f

📥 Commits

Reviewing files that changed from the base of the PR and between 18d17ba and 3e0de38.

⛔ Files ignored due to path filters (1)
  • frontend/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • frontend/package.json
  • frontend/src/router/index.ts
✅ Files skipped from review due to trivial changes (1)
  • frontend/package.json

📝 Walkthrough

Walkthrough

Adjusts the router catch-all redirect to handle missing params and builds a /files/... destination correctly; also bumps @vitejs/plugin-legacy in frontend/package.json from ^8.0.1 to ^8.0.2.

Changes

Frontend changes

Layer / File(s) Summary
Catch-all route redirect logic
frontend/src/router/index.ts
Replaced the catch-all route's inline redirect with a redirect: (to: RouteLocation) => { ... } function that returns "/files/" when to.params.catchAll is absent, or /files/<joined> when present.
Update Vite legacy plugin version
frontend/package.json
Bumped @vitejs/plugin-legacy devDependency from ^8.0.1 to ^8.0.2.

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title states 'update vitejs/plugin-legacy version', but the changeset includes a significant update to router catch-all redirect logic in addition to the version bump. Update the title to reflect both changes, such as 'chore: update vitejs/plugin-legacy and fix router catch-all redirect logic' or provide clarification if the router change is unintended.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-vitejs/plugin-legacy

Comment @coderabbitai help to get the list of available commands and usage tips.

@laurynasgadl laurynasgadl force-pushed the chore/update-vitejs/plugin-legacy branch from 18d17ba to 3e0de38 Compare June 8, 2026 12:03
@laurynasgadl laurynasgadl merged commit 2b1fae7 into master Jun 8, 2026
5 checks passed
@laurynasgadl laurynasgadl deleted the chore/update-vitejs/plugin-legacy branch June 8, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant