Skip to content

feat: Replace Horde_Template with Horde_View #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TDannhauer merged 1 commit into from
Apr 9, 2026
Merged

feat: Replace Horde_Template with Horde_View #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,12 @@
'name' => 'hermes/hours',
'params' => $criteria));

$template = new Horde_Template();
$template->setOption('gettext', true);
$template->set('postUrl', Horde::url('time.php', false, -1));
$template->set('sessionId', Horde_Util::formInput());
$template->set('table', $table->render());
$view = new Horde_View(['templatePath' => HERMES_TEMPLATES . '/time']);
$view->postUrl = Horde::url('time.php', false, -1);
$view->sessionId = Horde_Util::formInput();
$view->table = $table->render();

echo $template->fetch(HERMES_TEMPLATES . '/time/form.html');
echo $view->render('form');
}

echo '<br />';
Expand Down
6 changes: 0 additions & 6 deletions templates/time/form.html
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions templates/time/form.html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<form method="post" action="<?php echo $this->postUrl ?>">
<?php echo $this->sessionId ?>
<input type="hidden" name="formname" value="submittimeform" />
<?php echo $this->table ?>
<input class="horde-default" type="submit" name="submit" value="<?php echo _("Submit Selected Time") ?>" />
</form>
11 changes: 5 additions & 6 deletions time.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,15 @@
'params' => $criteria)
);

$template = new Horde_Template();
$template->setOption('gettext', true);
$template->set('postUrl', Horde::url('time.php', false, -1));
$template->set('sessionId', Horde_Util::formInput());
$template->set('table', $table->render());
$view = new Horde_View(['templatePath' => HERMES_TEMPLATES . '/time']);
$view->postUrl = Horde::url('time.php', false, -1);
$view->sessionId = Horde_Util::formInput();
$view->table = $table->render();

$page_output->header(array(
'title' => _("My Time")
));
$notification->notify(array('listeners' => 'status'));
echo $tabs;
echo $template->fetch(HERMES_TEMPLATES . '/time/form.html');
echo $view->render('form');
$page_output->footer();