Create index(es) for optional named parameters in init() method #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possibility that some named parameters for
init()would be omitted when passed toaddVariable()/addHidden()/insertVariableBefore().Suppose we have this:
Calling
addVariable()with$params = [ 'parm1' => 'abc', 'parm2' => 123 ]results ininit(...$params)called with$params = [ 0 => 'abc', 1 => 123 ], which is correct.But if
parm1is omitted, i.e.$params = [ 'parm2' => 123 ], theninit(...$params)would be called with$params = [ 1 => 123 ]. However PHP converts this internally to$params = [ 0 => 123 ], which results in the wrong parameter assignment -parm1(notparm2) gets assigned123.This PR addresses handling of omitted parameters (we do not seem to have cases like that though) by making sure indexes for such parameters exist.
With this PR the
paramsin the previous example becomes[ 0 => null, 1 => 123 ], which fixes the issue.