Conversation
home-assistant
Bot
added
cla-signed
dependency
|
Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
mib1185
commented
Jan 25, 2026
| LOGGER.debug("enable smarthome triggers: %s", self.has_triggers) | ||
|
|
||
| self.configuration_url = self.fritz.get_prefixed_host() | ||
| self.configuration_url = self.fritz.base_url |
Member
Author
There was a problem hiding this comment.
the get_prefixed_host() method has been replaced by the base_url property in hthiery/python-fritzhome#126
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the pyfritzhome library dependency from version 0.6.18 to 0.6.19, which includes an API change where the get_prefixed_host() method has been replaced with a base_url property.
Changes:
- Updated pyfritzhome dependency version to 0.6.19 in manifest and requirements files
- Replaced
get_prefixed_host()method call withbase_urlproperty access in coordinator - Updated test fixture mock to use
base_urlproperty instead ofget_prefixed_host()method
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/fritzbox/manifest.json | Updated pyfritzhome requirement to version 0.6.19 |
| requirements_all.txt | Updated pyfritzhome dependency to version 0.6.19 |
| requirements_test_all.txt | Updated pyfritzhome test dependency to version 0.6.19 |
| homeassistant/components/fritzbox/coordinator.py | Changed from calling get_prefixed_host() method to accessing base_url property |
| tests/components/fritzbox/conftest.py | Updated test fixture mock to use base_url property instead of get_prefixed_host() return value |
flabbamann
approved these changes
Jan 25, 2026
Contributor
flabbamann
left a comment
flabbamann
left a comment
There was a problem hiding this comment.
LGTM 👍 Thank you @mib1185!
chemelli74
approved these changes
Jan 25, 2026
zweckj
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
release-notes: https://github.com/hthiery/python-fritzhome/releases/tag/0.6.19
diff: hthiery/python-fritzhome@0.6.18...0.6.19
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: