Update Snoo strings.json to include weaning_baseline#154268
Merged
joostlek merged 1 commit intohome-assistant:devfrom Oct 12, 2025
Merged
Update Snoo strings.json to include weaning_baseline#154268joostlek merged 1 commit intohome-assistant:devfrom
joostlek merged 1 commit intohome-assistant:devfrom
Conversation
Lash-L/python-snoo#44 updates `SnooLevels` to include `weaning_baseline`, but there's no corresponding string here, so HA just shows the raw "weaning_baseline" value. This adds "Baseline (Weaning)" as a human-readable string for that enum value.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
Author
|
Given that this is for the Snoo integration, CC @Lash-L (and let me know if there's any changes you'd like me to make or any local testing that would be helpful here). Edit: oops didn't know the bot would CC you, sorry for the double-CC. |
Contributor
Author
joostlek
approved these changes
Oct 12, 2025
davidrecordon
pushed a commit
to davidrecordon/home-assistant-core
that referenced
this pull request
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed change
Right now, the Snoo integration has a state value (
weaning_baseline) that doesn't have a human-readable string associated with it, so it shows up to the end-user in that form. This adds a human-readable string for that value.Type of change
Additional information
Lash-L/python-snoo#44 updates
SnooLevelsto includeweaning_baseline, but there's no corresponding string here, so HA just shows the raw "weaning_baseline" value (see attached image).So this PR adds "Baseline (Weaning)" as a human-readable string for that enum value. I'm open to alternative translations here, this seemed to match what I would expect.
If there's a clean way to test this locally, let me know; given that it's a strings-only change, though, it seems like it should be pretty safe.
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: