Skip to content

Use pyephember2 library in ephember#140459

Merged
MartinHjelmare merged 30 commits intohome-assistant:devfrom
Zaduvalo:pyephember_next_version
Apr 16, 2025
Merged

Use pyephember2 library in ephember#140459
MartinHjelmare merged 30 commits intohome-assistant:devfrom
Zaduvalo:pyephember_next_version

Conversation

@Zaduvalo
Copy link
Copy Markdown
Contributor

@Zaduvalo Zaduvalo commented Mar 12, 2025

Breaking change

Proposed change

New pyephember library support.
New devices support added.
Multiple home support

New library diff - https://github.com/ttroy50/pyephember/pull/19/files
Library github link - https://github.com/roberty99/pyephember2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown

Hey there @ttroy50, mind taking a look at this pull request as it has been labeled with an integration (ephember) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ephember can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ephember Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Zaduvalo
Copy link
Copy Markdown
Contributor Author

@Zaduvalo Zaduvalo marked this pull request as ready for review March 29, 2025 23:50
frenck
frenck previously requested changes Mar 30, 2025
Comment thread homeassistant/components/ephember/manifest.json Outdated
@home-assistant home-assistant bot marked this pull request as draft March 30, 2025 15:05
@home-assistant
Copy link
Copy Markdown

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@roberty99 roberty99 mentioned this pull request Mar 31, 2025
19 tasks
Comment thread homeassistant/components/ephember/climate.py Outdated
@Zaduvalo Zaduvalo marked this pull request as ready for review March 31, 2025 16:00
@MartinHjelmare MartinHjelmare marked this pull request as draft April 4, 2025 18:04
@Zaduvalo Zaduvalo marked this pull request as ready for review April 7, 2025 12:40
@home-assistant home-assistant bot requested a review from MartinHjelmare April 7, 2025 12:40
Comment thread homeassistant/components/ephember/climate.py Outdated
Comment thread homeassistant/components/ephember/climate.py Outdated
Comment thread homeassistant/components/ephember/climate.py Outdated
@MartinHjelmare MartinHjelmare marked this pull request as draft April 7, 2025 13:32
@Zaduvalo Zaduvalo marked this pull request as ready for review April 8, 2025 17:12
@home-assistant home-assistant bot requested a review from MartinHjelmare April 8, 2025 17:12
Comment thread homeassistant/components/ephember/climate.py Outdated
@MartinHjelmare MartinHjelmare marked this pull request as draft April 9, 2025 09:36
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@Zaduvalo Zaduvalo marked this pull request as ready for review April 9, 2025 16:11
@home-assistant home-assistant bot requested a review from MartinHjelmare April 9, 2025 16:11
@Zaduvalo
Copy link
Copy Markdown
Contributor Author

Hi @MartinHjelmare , @frenck, is anything needed to complete PR?

@MartinHjelmare
Copy link
Copy Markdown
Member

CI need to pass. Every time you merge dev or rebase on dev the CI result is lost and we need to run CI again. Unless the feature branch needs something from dev or there's a merge conflict you generally don't need to merge dev or rebase.

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Apr 15, 2025

Please add a link to the new library GitHub repo in the PR description.

@Zaduvalo
Copy link
Copy Markdown
Contributor Author

Please add a link to the new library GitHub repo in the PR description.

Github link added. No more branch updates.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Pyephember next version Use pyephember2 library Apr 16, 2025
@MartinHjelmare MartinHjelmare changed the title Use pyephember2 library Use pyephember2 library in ephember Apr 16, 2025
@MartinHjelmare MartinHjelmare dismissed frenck’s stale review April 16, 2025 08:43

Comment addressed

@MartinHjelmare MartinHjelmare merged commit c96bb45 into home-assistant:dev Apr 16, 2025
47 of 48 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
@joostlek
Copy link
Copy Markdown
Member

joostlek commented May 6, 2025

Mind sending me a message on discord so we can add you to the relevant channels?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants