Reinstate last set of pre-existing health connect sensors#6588
Reinstate last set of pre-existing health connect sensors#6588TimoPtr merged 3 commits intohome-assistant:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the Health Connect integration by enabling additional body/measurement sensors and declaring the corresponding Android Health permissions, so these data types can be exposed and read when available.
Changes:
- Enable additional Health Connect sensors in the available sensor list (e.g., basal body temperature, basal metabolic rate, body temperature, height, hydration)
- Add the corresponding
android.permission.health.READ_*permissions to the app manifest
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthConnectSensorManager.kt | Adds more Health Connect sensors to getAvailableSensors() so they can be surfaced in the app |
| app/src/main/AndroidManifest.xml | Declares additional Health permissions required for the newly enabled Health Connect data types |
You can also share your feedback on Copilot code review. Take the survey.
| <!-- <uses-permission android:name="android.permission.health.READ_LEAN_BODY_MASS" />--> | ||
| <uses-permission android:name="android.permission.health.READ_HEIGHT" /> | ||
| <uses-permission android:name="android.permission.health.READ_HYDRATION" /> | ||
| <uses-permission android:name="android.permission.health.READ_LEAN_BODY_MASS" /> |
|
Personally I'm not really in favor considering how annoying Google has been with Health Connect in the past, even questioning previously granted usages. However if you think we have a real shot now I won't object. |
|
Unfortunately the only way to really tell if we can add more sensors is to test the waters. We can try and reduce this count if we feel its too high. I do agree this can definitely trigger another dreaded review cycle lol. |
|
My concern is more general, not about the number. In other words: I told you so if we get stuck in a review cycle again ;). |
|
@dshokouhi could you add a changelog entry? |
@dshokouhi Friendly reminder as we want to merge tomorrow :) |
|
Sorry for the delay guys 🙏 |
|
hmm not really sure why the build is failing 🤔 |
|
The Wear on API 34 instrumentation test has been flaky for me as well. I don't think it's related, retry usually resolves it. |
Summary
As it has been a while since we made any Health Connect changes and have not had any issues with play store review lets reinstate the last set of commented out sensors before revisiting what remains
Checklist
Screenshots
Link to pull request in documentation repositories
User Documentation: home-assistant/companion.home-assistant#pending
Any other notes
once merged we should update the play console listing for these 8 sensors to match the existing template used like in daily steps
also to speed up play store review process we need to also cut a new beta while submitting the updated policy changes. We should do all that in one go. Merge, Update Play store, tag new beta.