Skip to content

Reinstate last set of pre-existing health connect sensors#6588

Merged
TimoPtr merged 3 commits intohome-assistant:mainfrom
dshokouhi:hc_2026_03
Apr 15, 2026
Merged

Reinstate last set of pre-existing health connect sensors#6588
TimoPtr merged 3 commits intohome-assistant:mainfrom
dshokouhi:hc_2026_03

Conversation

@dshokouhi
Copy link
Copy Markdown
Member

@dshokouhi dshokouhi commented Mar 18, 2026

Summary

As it has been a while since we made any Health Connect changes and have not had any issues with play store review lets reinstate the last set of commented out sensors before revisiting what remains

  • Basal body temperature
  • basal metabolic rate
  • body temp
  • body water mass
  • bone mass
  • daily hydration
  • height
  • lean body mass

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Screenshots

image

Link to pull request in documentation repositories

User Documentation: home-assistant/companion.home-assistant#pending

Any other notes

once merged we should update the play console listing for these 8 sensors to match the existing template used like in daily steps

also to speed up play store review process we need to also cut a new beta while submitting the updated policy changes. We should do all that in one go. Merge, Update Play store, tag new beta.

Copilot AI review requested due to automatic review settings March 18, 2026 18:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the Health Connect integration by enabling additional body/measurement sensors and declaring the corresponding Android Health permissions, so these data types can be exposed and read when available.

Changes:

  • Enable additional Health Connect sensors in the available sensor list (e.g., basal body temperature, basal metabolic rate, body temperature, height, hydration)
  • Add the corresponding android.permission.health.READ_* permissions to the app manifest

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
app/src/main/kotlin/io/homeassistant/companion/android/sensors/HealthConnectSensorManager.kt Adds more Health Connect sensors to getAvailableSensors() so they can be surfaced in the app
app/src/main/AndroidManifest.xml Declares additional Health permissions required for the newly enabled Health Connect data types

You can also share your feedback on Copilot code review. Take the survey.

<!-- <uses-permission android:name="android.permission.health.READ_LEAN_BODY_MASS" />-->
<uses-permission android:name="android.permission.health.READ_HEIGHT" />
<uses-permission android:name="android.permission.health.READ_HYDRATION" />
<uses-permission android:name="android.permission.health.READ_LEAN_BODY_MASS" />
@jpelgrom
Copy link
Copy Markdown
Member

Personally I'm not really in favor considering how annoying Google has been with Health Connect in the past, even questioning previously granted usages. However if you think we have a real shot now I won't object.

@dshokouhi
Copy link
Copy Markdown
Member Author

Unfortunately the only way to really tell if we can add more sensors is to test the waters. We can try and reduce this count if we feel its too high. I do agree this can definitely trigger another dreaded review cycle lol.

@jpelgrom
Copy link
Copy Markdown
Member

My concern is more general, not about the number. In other words: I told you so if we get stuck in a review cycle again ;).

@TimoPtr
Copy link
Copy Markdown
Member

TimoPtr commented Mar 30, 2026

@dshokouhi could you add a changelog entry?

@jpelgrom
Copy link
Copy Markdown
Member

could you add a changelog entry?

@dshokouhi Friendly reminder as we want to merge tomorrow :)

@dshokouhi
Copy link
Copy Markdown
Member Author

Sorry for the delay guys 🙏

@dshokouhi
Copy link
Copy Markdown
Member Author

hmm not really sure why the build is failing 🤔

@jpelgrom
Copy link
Copy Markdown
Member

The Wear on API 34 instrumentation test has been flaky for me as well. I don't think it's related, retry usually resolves it.

@TimoPtr TimoPtr merged commit 10d9dba into home-assistant:main Apr 15, 2026
68 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants