Add missing supported domains in the wear for tiles#6587
Open
Add missing supported domains in the wear for tiles#6587
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores Wear OS tile entity selection for Camera and Thermostat tiles by re-adding the missing camera and climate domains to the Wear-supported domain list after a refactor.
Changes:
- Add
"camera"domain mapping tocommonR.string.domain_camera - Add
"climate"domain mapping tocommonR.string.domain_climate - As a result, Wear’s
supportedDomainsfiltering will include these domains again (enabling entity lists for the corresponding tiles)
Member
Member
Author
|
I've made a change to keep a temporary list in the view State. I'm not a fan since it adds another attributes to already big state, but I don't want to introduce another side effect. |
Contributor
Test Results 205 files 213 suites 5m 23s ⏱️ Results for commit 31d22ed. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
It seems that during the refactor of the MainViewModel, we trimmed the entities that were not supported meaning it missed a domain translation. This PR adds two missing translation so that we can use CameraTile and ClimateTile again.
I might have missed some other but let see.
It closes #6573
Checklist