Skip to content

Add missing supported domains in the wear for tiles#6587

Open
TimoPtr wants to merge 4 commits intomainfrom
fix/missing_supported_domain_climate_camera
Open

Add missing supported domains in the wear for tiles#6587
TimoPtr wants to merge 4 commits intomainfrom
fix/missing_supported_domain_climate_camera

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Mar 18, 2026

Summary

It seems that during the refactor of the MainViewModel, we trimmed the entities that were not supported meaning it missed a domain translation. This PR adds two missing translation so that we can use CameraTile and ClimateTile again.

I might have missed some other but let see.

It closes #6573

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores Wear OS tile entity selection for Camera and Thermostat tiles by re-adding the missing camera and climate domains to the Wear-supported domain list after a refactor.

Changes:

  • Add "camera" domain mapping to commonR.string.domain_camera
  • Add "climate" domain mapping to commonR.string.domain_climate
  • As a result, Wear’s supportedDomains filtering will include these domains again (enabling entity lists for the corresponding tiles)

@jpelgrom
Copy link
Member

I came to the same conclusion for the cause yesterday, but simply adding the domains here introduces the unwanted side effect of these domains also showing up in the 'main app' where you cannot interact with them. They should only be shown in the selection UI for the specific tile/complication.

image

@TimoPtr
Copy link
Member Author

TimoPtr commented Mar 19, 2026

I've made a change to keep a temporary list in the view State. I'm not a fan since it adds another attributes to already big state, but I don't want to introduce another side effect.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

Test Results

  205 files    213 suites   5m 23s ⏱️
1 223 tests 1 223 ✅ 0 💤 0 ❌
1 266 runs  1 258 ✅ 8 💤 0 ❌

Results for commit 31d22ed.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to choose any camera entity for Camera tile

3 participants