Skip to content

Use goAsync to invoke the WebSocketManager.start#6543

Open
TimoPtr wants to merge 1 commit intofeature/go_async_high_accuracy_disablefrom
feature/go_async_websocket_receiver
Open

Use goAsync to invoke the WebSocketManager.start#6543
TimoPtr wants to merge 1 commit intofeature/go_async_high_accuracy_disablefrom
feature/go_async_websocket_receiver

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Mar 5, 2026

Summary

The call to WebSocketManager.start can be a bit slow since it needs to cancel previous job and send await. We should do that using goAsync to let know the system that it is still alive.

image (last 7 days)

It seems to be mostly on old devices (bellow Android 12)

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Any other notes

Based on #6467

@TimoPtr TimoPtr requested a review from jpelgrom March 5, 2026 14:16
@TimoPtr TimoPtr force-pushed the feature/go_async_websocket_receiver branch from 5ed748f to 42517c8 Compare March 18, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant