Skip to content

Conversation

@kamalsaleh
Copy link
Member

bump version to v2025.11-01

bump version to v2025.11-01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the package to comply with GAP 4.15.1 requirements by modernizing the global variable declaration pattern and bumping the version to 2025.11-01. The changes include both code updates and corresponding test output adjustments.

  • Replaced InstallValue with DeclareGlobalVariable pattern with the modern BindGlobal approach for SkeletalSmoothMaps
  • Updated minimum GAP version requirement from 4.13.0 to 4.15.1
  • Updated test expectations to reflect improved formatting (removal of redundant parentheses in expression output)

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
PackageInfo.g Updated version to 2025.11-01 and minimum GAP requirement to 4.15.1
gap/CategoryOfSkeletalSmoothMaps.gd Removed DeclareGlobalVariable declaration for SkeletalSmoothMaps
gap/CategoryOfSkeletalSmoothMaps.gi Changed from InstallValue to BindGlobal for SkeletalSmoothMaps definition
tst/example-in-readme-1.tst Removed blank line in test output
tst/example-in-readme-2.tst Updated test expectations to match improved expression formatting (fewer parentheses)
examples/Expressions.g Updated expected output comments to match improved expression formatting
examples/CategoryOfSkeletalSmoothMaps.g Updated expected output comments to match improved expression formatting
examples/CategoryOfLenses.g Updated expected output comments to match improved expression formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@kamalsaleh kamalsaleh merged commit 9c076aa into homalg-project:master Nov 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant