Skip to content

misc: add copywriting for session expired modal#31

Merged
nguyenalter merged 1 commit into
mainfrom
misc/add-copy-writing-for-session-expired-modal
May 29, 2026
Merged

misc: add copywriting for session expired modal#31
nguyenalter merged 1 commit into
mainfrom
misc/add-copy-writing-for-session-expired-modal

Conversation

@nguyenalter
Copy link
Copy Markdown
Contributor

Summary

misc: add copywriting for session expired modal

Issue

(issue link here)

Lasting Changes (Technical)

N/A

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Lint Checks Passed
  • Unit Tests Passed
  • Coverage Tests Passed
  • Integration Tests Passed
  • Code Review

@nguyenalter nguyenalter requested a review from huyleminh01 May 29, 2026 07:59
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds localization strings for a new "session expired" modal across multiple languages (English, Japanese, Portuguese, Turkish, Vietnamese, and Chinese) and bumps the package version to 1.1.15. The review feedback suggests improving the English and Portuguese translations by splitting comma-spliced sentences into two separate sentences for better grammatical correctness.

Comment thread locales/en/modals.yaml
Comment thread locales/pt-BR/modals.yaml
@nguyenalter nguyenalter merged commit ebc2ec7 into main May 29, 2026
1 check passed
@nguyenalter nguyenalter deleted the misc/add-copy-writing-for-session-expired-modal branch May 29, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants