Remove the need to parse the Markdown to extract the markdown title#5
Merged
StefanAndreevHX merged 2 commits intomainfrom Jan 19, 2026
Merged
Conversation
StefanAndreevHX
commented
Dec 30, 2025
StefanAndreevHX
commented
- Add MarkdownLinkClickConfiguration with url, title, and isImage properties
- Add openMarkdownLink environment value for custom link handling
- Add URL extension helpers for encoding/extracting titles in text links
- Update ImageView to pass title through LinkModifier
- Add LinksView demo showing both image and text link handling
…ment for accessing link title at click time - Add MarkdownLinkClickConfiguration with url, title, and isImage properties - Add openMarkdownLink environment value for custom link handling - Add URL extension helpers for encoding/extracting titles in text links - Update ImageView to pass title through LinkModifier - Add LinksView demo showing both image and text link handling
dpetrov-appolica
previously approved these changes
Jan 9, 2026
Collaborator
dpetrov-appolica
left a comment
dpetrov-appolica
left a comment
There was a problem hiding this comment.
Looks good to me.
Tsvetan11
previously approved these changes
Jan 13, 2026
…lity for testing the flow
StefanAndreevHX
dismissed stale reviews from Tsvetan11 and dpetrov-appolica
via
0c5c2d2
| } | ||
| .environment(\.openMarkdownLink) { configuration in | ||
| .environment(\.openMarkdownLink) { [self] configuration in | ||
| print("Handler called: \(configuration.title)") |
Collaborator
There was a problem hiding this comment.
If those prints were only for debugging purpose, remove them.
Author
There was a problem hiding this comment.
I've added them for debugging, to prove/debug if it work.
dpetrov-appolica
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.