Adding registerSchema to builder #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewosh
force-pushed
the
new-builder-api
branch
from
45538b5 to
1b52040
Compare
Contributor
Author
|
This doesn't work when reloading a spec from a JSON file, as that will immediately generate the collections/indexes in the constructor. We would need to either defer the creation of these, or pass the schema to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the signature of
HyperDB.from(schemaDir, dbDir)toHyperDB.from(dbDir)and adds aregisterSchemamethod for registering a hyperschema instance afterfrom.This makes composition easier (hyperdb isn't responsible for persisting the schema anymore), and also lets us deduplicate messages.js files on disk.