Skip to content

use signedLength instead of indexedLength #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HDegroote merged 1 commit into from
Feb 21, 2025
Merged

use signedLength instead of indexedLength #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function createUnionMap (keyEncoding, valueEncoding) {

if (!haveSameNewValue) {
// apply-entry wins, but the previous state (.right) is not the value
// at the last indexedLength, since a diffEntry to undo exists for the same key
// at the last signedLength, since a diffEntry to undo exists for the same key
// So we yield that to-undo diffEntry's final state as previous state for this change
return filterSameValue({
left: decode(applyDiffEntry.left),
Expand Down Expand Up @@ -85,13 +85,13 @@ class BeeDiffStream extends Union {
// Binary encodings for easier comparison later
opts = { ...opts, gt, gte, lt, lte, valueEncoding: 'binary', keyEncoding: 'binary' }

if (leftSnapshot.core.indexedLength === undefined) {
throw new Error('Incompatible Hypercore version--must have indexedLength property')
if (leftSnapshot.core.signedLength === undefined) {
throw new Error('Incompatible Hypercore version--must have signedLength property')
}

// We know that everything indexed in both snapshots is shared
const sharedIndexedL = Math.min(
leftSnapshot.core.indexedLength, rightSnapshot.core.indexedLength
leftSnapshot.core.signedLength, rightSnapshot.core.signedLength
)

// TODO: consider optimisation for case where the version of both streams
Expand Down