Link to plain preview for rendered files #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbachhuber
commented
Aug 8, 2025
cbachhuber
commented
Aug 8, 2025
Comment on lines
+7
to
+8
| - push | ||
| - pull_request |
Contributor
Author
There was a problem hiding this comment.
@hogashi, I'd like to verify in my PR that the tests I added work. Can you approve this workflow change (not the PR itself yet)? See also https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks
Contributor
Author
There was a problem hiding this comment.
Fixed the tests, they now pass locally. I'm opening the PR for review. Still, I'd appreciate having it gated by CI.
$ jest
PASS src/__tests__/makeHttpsUrl.test.ts
PASS src/__tests__/extension.test.ts
Test Suites: 2 passed, 2 total
Tests: 15 passed, 15 total
Snapshots: 0 total
Time: 2.945 s
Ran all test suites.
Done in 11.55s.
hogashi
approved these changes
Aug 12, 2025
Owner
hogashi
left a comment
hogashi
left a comment
There was a problem hiding this comment.
Thank you for the PR! I granted workflow.
I missed markdown (and other rich docs format) and it looks good. Adding tests also helps me a lot!
Owner
|
this will be published as v0.5.0 🚀 https://github.com/hogashi/vscode-copy-github-permalink/releases/tag/v0.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this great extension! I often find myself wanting to link to specific lines in markdown files, but that's swallowed by GitHub's preview function. See for example
https://github.com/hogashi/vscode-copy-github-permalink/blob/f666c57d7e2cf1cdff26ca8cf87d918a2b990d8b/README.md#L9I need to manually click on the plain preview button or modify the URL to
https://github.com/hogashi/vscode-copy-github-permalink/blob/f666c57d7e2cf1cdff26ca8cf87d918a2b990d8b/README.md?plain=1#L9to get the linked line highlighted. Automated with this PR.