This repository was archived by the owner on Sep 20, 2021. It is now read-only.
Open
Conversation
ghost
assigned
vonglasow
suggested changes
Sep 9, 2018
Member
vonglasow
left a comment
vonglasow
left a comment
There was a problem hiding this comment.
Thanks for your PR can you rebase it from master and also fix the conflict ;)
| */ | ||
| public static function store (array $contain) { | ||
|
|
||
| if(false === is_array($contain)) |
Member
There was a problem hiding this comment.
Not needed as it's already defined as type of argument.
|
|
||
| throw new Exception( | ||
| 'Cannot instance the %s object. Use set, get, remove ' . | ||
| 'Cannot instance the %s object. Use set, get,store, remove ' . |
Member
|
@maitrepylos it's rebased now it's operational you can add unit tests to cover the case. Thanks |
Member
|
ping @maitrepylos do you need any help about it ? |
Member
Author
|
ping @vonglasow Hi, are you asking me to run tests? I don't know where to start! |
Member
|
it was to add some tests to cover your feature we can discuss about it on IRC to help you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, for one of my projects, I use Registry and I added a method to pass a configuration array, and it's easy for me to do it like that rather than using the set() method every time.