Conversation
… backpressure (Refs: beans-x0zh) - Change AgentSessionChanged and ActiveAgentStatuses resolvers to use a latest-value pattern instead of blocking on send - When a new notification arrives while the resolver is blocked sending to the WebSocket transport, refresh the pending state so the frontend always receives the most recent session status - Add test for latest-value delivery under rapid notifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentSessionChangedandActiveAgentStatusessubscription resolvers blocked on sending each payload to the WebSocket transport via an unbufferedoutchannel. While blocked, new notifications on the buffer-1 notification channel were silently dropped. This could cause the frontend to miss entire RUNNING status transitions, making the "Agent is working..." spinner disappear while the agent was still active.TestAgentSessionSubscription_DeliversLatestStateto verify correct delivery under rapid notifications.Test plan
mise test— all Go tests pass