This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Fix parsing from std::cin (tellg/seekg are not working for it).#62
Open
SergiusTheBest wants to merge 1 commit intohjiang:masterfrom
Open
Fix parsing from std::cin (tellg/seekg are not working for it).#62SergiusTheBest wants to merge 1 commit intohjiang:masterfrom
SergiusTheBest wants to merge 1 commit intohjiang:masterfrom
Conversation
Owner
|
This change would break the test at But it seems to work fine on Linux. Interesting. |
Author
|
I checked on Windows and Linux. So it looks it depends on istream implementation. |
Author
|
By the way, thanks for the good library. It's small and very easy to use. Nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I fixed parsing from std::cin. The problem was in tellg/seekg that break std::cin (and it looks they are not required at all, so I removed them).
You can reproduce the issue with the following sample:
Send this json to stdin: