Differentiate Integer type from Double type (which was originally named Number) to make it possible to correctly store a 64bit integer on 32bit systems.#41
Conversation
Number), make it possible to correctly store a 64bit integer on 32bit systems. Note: this commit will stop programs that use the original **jsonxx** lib from compiling. it is required to change the enum *Number* to either *Integer* or *Double* accordingly.
|
Since this PR is a breaking change, I recommend adding back the |
|
@Rapptz, I think adding back the |
|
what about adding the compatibility enum with a comment like following? |
|
It's okay to me :) |
|
Hi, I would prefer an implementation that respects the RFC: "The representation of numbers is similar to that used in most Why not just address all these problematic programmatically instead ? I think in Number, we address something that can be a float or a pure integer. Internally we can build a more complex structure that switches between long or double. Just my point of view :-) |
Differentiate Integer type from Double type (which was originally named Number), make it possible to correctly store a 64bit integer on 32bit
systems.
Note: this commit will stop programs that use the original jsonxx lib
from compiling. it is required to change the enum Number to either
Integer or Double accordingly.