Implement i64.load instruction #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the `i64.load` instruction to the WebAssembly interpreter. The following changes were made: - Added `I64Load` class to `Module.java` to represent the instruction. - Added `readInt64` method to `Memory.java` to read a 64-bit integer from memory. - Updated `Parser.java` to parse the `i64.load` instruction (opcode 0x29). - Added unit tests for `i64.load` in `I64Test.java` and a corresponding `i64_load_test.wasm` file. These verify loading from a base address and loading with an offset. - A temporary workaround was added to `Parser.java` in `parseExportSection` to correctly handle memory exports encountered in the new test WASM file. This prevents an `UnsupportedOperationException` during parsing of the test module. All tests in `I64Test` are confirmed to be passing after these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the
i64.loadinstruction to the WebAssembly interpreter.The following changes were made:
I64Loadclass toModule.javato represent the instruction.readInt64method toMemory.javato read a 64-bit integer from memory.Parser.javato parse thei64.loadinstruction (opcode 0x29).i64.loadinI64Test.javaand a correspondingi64_load_test.wasmfile. These verify loading from a base address and loading with an offset.Parser.javainparseExportSectionto correctly handle memory exports encountered in the new test WASM file. This prevents anUnsupportedOperationExceptionduring parsing of the test module.All tests in
I64Testare confirmed to be passing after these changes.