Skip to content

⚡ Bolt: Extract dynamic Regex to optimize HintExtractor performance #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himattm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Extract dynamic Regex to optimize HintExtractor performance #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2026-05-10 - Extract Dynamic Regex Declarations
**Learning:** In Kotlin, declaring `Regex` objects dynamically within functions incurs a performance penalty due to recompilation on every invocation.
**Action:** Always hoist frequently used regexes (e.g., `Regex("""\s+""")`) to class-level or object-level constants (e.g., `private val`) to optimize performance in hot paths.
3 changes: 2 additions & 1 deletion halogen-engine/src/commonMain/kotlin/halogen/engine/HintExtractor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ internal object HintExtractor {
private val CAMEL_SPLIT = Regex("""(?<=[a-z])(?=[A-Z])""")
private val ID_PATTERN = Regex("""^[0-9a-f]{8,}$""", RegexOption.IGNORE_CASE)
private val NUMERIC_ONLY = Regex("""^\d+$""")
private val WHITESPACE_PATTERN = Regex("""\s+""")

fun extract(key: String): String? {
if (key.isBlank()) return null
Expand All @@ -36,7 +37,7 @@ internal object HintExtractor {
cleaned = cleaned.replace('_', ' ').replace('-', ' ')

// Normalize whitespace
cleaned = cleaned.trim().replace(Regex("""\s+"""), " ")
cleaned = cleaned.trim().replace(WHITESPACE_PATTERN, " ")

if (cleaned.isBlank()) return null

Expand Down
Loading