Skip to content

⚡ Bolt: [performance improvement] Cache regex in HintExtractor #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himattm wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

⚡ Bolt: [performance improvement] Cache regex in HintExtractor #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion halogen-engine/src/commonMain/kotlin/halogen/engine/HintExtractor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ internal object HintExtractor {
private val ID_PATTERN = Regex("""^[0-9a-f]{8,}$""", RegexOption.IGNORE_CASE)
private val NUMERIC_ONLY = Regex("""^\d+$""")

// ⚡ Bolt: Cache regex to prevent recompilation on every extract call.
// Expected impact: Eliminates regex allocation/compilation overhead per extraction,
// saving memory and execution time in a hot path.
private val WHITESPACE = Regex("""\s+""")

fun extract(key: String): String? {
if (key.isBlank()) return null

Expand All @@ -36,7 +41,7 @@ internal object HintExtractor {
cleaned = cleaned.replace('_', ' ').replace('-', ' ')

// Normalize whitespace
cleaned = cleaned.trim().replace(Regex("""\s+"""), " ")
cleaned = cleaned.trim().replace(WHITESPACE, " ")

if (cleaned.isBlank()) return null

Expand Down
Loading