Skip to content

⚡ Bolt: Cache wasm manifest in memory#34

Closed
himattm wants to merge 1 commit intomainfrom
bolt-wasmjs-manifest-cache-16300322750952369918
Closed

⚡ Bolt: Cache wasm manifest in memory#34
himattm wants to merge 1 commit intomainfrom
bolt-wasmjs-manifest-cache-16300322750952369918

Conversation

@himattm
Copy link
Copy Markdown
Owner

@himattm himattm commented Apr 25, 2026

💡 What: Replaces repeated JSON parsing of the localStorage manifest with an in-memory manifestCache (initialized lazily) in KMP WasmJs.
🎯 Why: JSON decoding across the Kotlin/WasmJS interop boundary introduces significant performance overhead. Previously, the LocalStorageThemeCache read and parsed the __keys__ manifest from localStorage repeatedly on every put, evict, keys(), size(), etc.
📊 Impact: This heavily reduces main-thread blocking synchronous IO & JSON parsing, making WasmJS theme caching operations O(1) in-memory operations and massively faster when generating/loading multiple themes.
🔬 Measurement: Check the application metrics or profile the caching layer; WasmJS browser tests pass successfully and verify correctness is preserved.


PR created automatically by Jules for task 16300322750952369918 started by @himattm

Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@himattm
Copy link
Copy Markdown
Owner Author

himattm commented May 7, 2026

Closing as superseded by #35, which is the latest cleaned LocalStorageThemeCache manifest-cache optimization merged to main. Keeping one canonical implementation avoids merging multiple generated variants of the same change.

@himattm himattm closed this May 7, 2026
@himattm himattm deleted the bolt-wasmjs-manifest-cache-16300322750952369918 branch May 7, 2026 13:24
@google-labs-jules
Copy link
Copy Markdown

Closing as superseded by #35, which is the latest cleaned LocalStorageThemeCache manifest-cache optimization merged to main. Keeping one canonical implementation avoids merging multiple generated variants of the same change.

Understood. Acknowledging that this work is superseded by #35 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant