Skip to content

⚡ Bolt: Optimize JSON Decoding in WasmJs LocalStorageThemeCache#31

Closed
himattm wants to merge 2 commits into
mainfrom
bolt/wasmjs-cache-optimization-11524758317310708948
Closed

⚡ Bolt: Optimize JSON Decoding in WasmJs LocalStorageThemeCache#31
himattm wants to merge 2 commits into
mainfrom
bolt/wasmjs-cache-optimization-11524758317310708948

Conversation

@himattm
Copy link
Copy Markdown
Owner

@himattm himattm commented Apr 22, 2026

💡 What: Added an in-memory manifestCache to LocalStorageThemeCache to prevent re-parsing the manifest JSON string from localStorage on every cache operation.
🎯 Why: JSON parsing via kotlinx.serialization on the wasmJs target can be slow on the main thread. Accessing localStorage string values repeatedly compounded this problem.
📊 Impact: Eliminates O(N) JSON decoding overhead per cache read/write, dramatically speeding up ThemeCache operations on the web target.
🔬 Measurement: Verify by running web target tests (./gradlew :halogen-engine:wasmJsBrowserTest) or profiling the app before and after to observe fewer decodeFromString calls when the cache is hit multiple times.


PR created automatically by Jules for task 11524758317310708948 started by @himattm

… cache

Introduced an in-memory `manifestCache` to `LocalStorageThemeCache` on the wasmJs target.
This prevents the need to decode the JSON set of keys from `window.localStorage` on every
single cache read and write operation, which is a significant performance bottleneck for Kotlin/WasmJS.

Also added the required `.jules/bolt.md` learning entry.

Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

… cache

Introduced an in-memory `manifestCache` to `LocalStorageThemeCache` on the wasmJs target.
This prevents the need to decode the JSON set of keys from `window.localStorage` on every
single cache read and write operation, which is a significant performance bottleneck for Kotlin/WasmJS.

Also added the required `.jules/bolt.md` learning entry.

Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
@himattm
Copy link
Copy Markdown
Owner Author

himattm commented May 7, 2026

Closing as superseded by #35, which is the latest cleaned LocalStorageThemeCache manifest-cache optimization merged to main. Keeping one canonical implementation avoids merging multiple generated variants of the same change.

@himattm himattm closed this May 7, 2026
@himattm himattm deleted the bolt/wasmjs-cache-optimization-11524758317310708948 branch May 7, 2026 13:24
@google-labs-jules
Copy link
Copy Markdown

Closing as superseded by #35, which is the latest cleaned LocalStorageThemeCache manifest-cache optimization merged to main. Keeping one canonical implementation avoids merging multiple generated variants of the same change.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant