Skip to content

⚡ Bolt: [Cache Manifest Optimization]#30

Closed
himattm wants to merge 2 commits into
mainfrom
bolt/optimize-wasm-manifest-cache-8106597515145361714
Closed

⚡ Bolt: [Cache Manifest Optimization]#30
himattm wants to merge 2 commits into
mainfrom
bolt/optimize-wasm-manifest-cache-8106597515145361714

Conversation

@himattm
Copy link
Copy Markdown
Owner

@himattm himattm commented Apr 21, 2026

💡 What: Introduced an in-memory Set (manifestCache) that lazily loads the manifest string from localStorage once and is updated synchronously for put, evict, and clear operations.
🎯 Why: LocalStorageThemeCache previously deserialized the entire list of cached theme keys from browser localStorage on every operation. For example, readManifest() was called multiple times which involved window.localStorage.getItem and json.decodeFromString every time it's invoked. This is a significant bottleneck on the WebAssembly (wasmJs) target.
📊 Impact: Expected to significantly reduce I/O overhead from localStorage and eliminate excessive JSON parsing, making subsequent cache accesses instantaneous (O(1)).
🔬 Measurement: Verify by executing cache mutations and ensuring localStorage.getItem or JSON decodes are only run on the first cache access.


PR created automatically by Jules for task 8106597515145361714 started by @himattm

…d JSON parsing

Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…d JSON parsing

Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
@himattm
Copy link
Copy Markdown
Owner Author

himattm commented May 7, 2026

Closing as superseded by #35, which is the latest cleaned LocalStorageThemeCache manifest-cache optimization merged to main. Keeping one canonical implementation avoids merging multiple generated variants of the same change.

@himattm himattm closed this May 7, 2026
@himattm himattm deleted the bolt/optimize-wasm-manifest-cache-8106597515145361714 branch May 7, 2026 13:24
@google-labs-jules
Copy link
Copy Markdown

Closing as superseded by #35, which is the latest cleaned LocalStorageThemeCache manifest-cache optimization merged to main. Keeping one canonical implementation avoids merging multiple generated variants of the same change.

Understood. Acknowledging that this work is now superseded by #35 and stopping work on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant