Skip to content

⚡ Bolt: Add in-memory manifest cache to LocalStorageThemeCache#29

Closed
himattm wants to merge 1 commit intomainfrom
bolt/wasmjs-cache-manifest-12436222383997282008
Closed

⚡ Bolt: Add in-memory manifest cache to LocalStorageThemeCache#29
himattm wants to merge 1 commit intomainfrom
bolt/wasmjs-cache-manifest-12436222383997282008

Conversation

@himattm
Copy link
Copy Markdown
Owner

@himattm himattm commented Apr 19, 2026

💡 What: Added a lightweight in-memory cache layer (manifestCache) to LocalStorageThemeCache for the wasmJs target to track the keys array.
🎯 Why: LocalStorageThemeCache previously parsed the JSON manifest array from localStorage on every operation (e.g. size(), keys(), put(), evict()), which is very expensive when done repeatedly.
📊 Impact: Significantly reduces execution time and overhead for all cache operations by avoiding unnecessary JSON decoding, particularly important in a single-threaded WebAssembly browser environment.
🔬 Measurement: Execute ./gradlew :halogen-engine:wasmJsBrowserTest to ensure no functionality is broken. Performance improvement can be observed in reduced CPU usage and faster operation response times.


PR created automatically by Jules for task 12436222383997282008 started by @himattm

Introduced an in-memory `manifestCache` to avoid repeated and expensive
JSON parsing from localStorage during cache operations.

Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@himattm
Copy link
Copy Markdown
Owner Author

himattm commented May 7, 2026

Closing as superseded by #35, which is the latest cleaned LocalStorageThemeCache manifest-cache optimization merged to main. Keeping one canonical implementation avoids merging multiple generated variants of the same change.

@himattm himattm closed this May 7, 2026
@himattm himattm deleted the bolt/wasmjs-cache-manifest-12436222383997282008 branch May 7, 2026 13:24
@google-labs-jules
Copy link
Copy Markdown

Closing as superseded by #35, which is the latest cleaned LocalStorageThemeCache manifest-cache optimization merged to main. Keeping one canonical implementation avoids merging multiple generated variants of the same change.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant