Skip to content

Fix parent composite status after ghost child cleanup #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+1 −23
Closed

Fix parent composite status after ghost child cleanup #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8329677
Initial plan
Copilot Feb 7, 2026
e48d3f7
Fix: Remove parent composite from destroy phase during ghost cleanup
Copilot Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/platform/backend/src/orchestrator/operation-plan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,18 +656,11 @@ function findGhostCleanup(
): OperationPhaseInstance[] {
const ghosts: OperationPhaseInstance[] = []

// find ghost instances and their parent composites that need cleanup
// find ghost instances that need cleanup
for (const instanceId of compositesNeedingGhostCleanup) {
const instance = context.getInstance(instanceId)
if (instance.kind !== "composite") continue

// add the composite itself for destroy if needed
ghosts.push({
id: instanceId,
parentId: instance.parentId,
message: "included in operation",
})

// find ghost children
const children = context.getInstanceChildren(instanceId)
for (const child of children) {
Expand Down
15 changes: 0 additions & 15 deletions packages/platform/backend/src/orchestrator/operation-plan.update.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,6 @@ describe("OperationPlan - Update Operations", () => {
[
{
"instances": [
{
"id": "composite.v1:Parent",
"message": "explicitly requested",
"parentId": undefined,
},
{
"id": "component.v1:GhostChild",
"message": "ghost cleanup",
Expand Down Expand Up @@ -360,11 +355,6 @@ describe("OperationPlan - Update Operations", () => {
[
{
"instances": [
{
"id": "composite.v1:Parent",
"message": "explicitly requested",
"parentId": undefined,
},
{
"id": "component.v1:GhostChild",
"message": "ghost cleanup",
Expand Down Expand Up @@ -986,11 +976,6 @@ describe("OperationPlan - Update Operations", () => {
},
{
"instances": [
{
"id": "composite.v1:Parent",
"message": "explicitly requested",
"parentId": undefined,
},
{
"id": "component.v1:GhostChild",
"message": "ghost cleanup",
Expand Down