Skip to content

feat: returned For in Graduations #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
high1 merged 1 commit into from
Jan 20, 2026
Merged

feat: returned For in Graduations #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/Graduations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { For } from 'solid-js';

import { ClockLine as Graduation } from '@/ClockLine';
import { rotate, seconds } from '@/common';

// For not used because Graduations are static - minor optimization
export const Graduations = () =>
[...Array(seconds).keys()]
.map<[boolean, number]>((index) => [index % 5 === 0, index])
.map(([isHour, index]) => (
export const Graduations = () => (
<For each={Array.from({ length: seconds }, (_, index) => index % 5 === 0)}>
{(isHour, index) => (
<Graduation
class={
isHour
Expand All @@ -14,6 +14,8 @@ export const Graduations = () =>
}
graduation
length={isHour ? 6 : 2.5}
transform={rotate(index / seconds, 0)}
transform={rotate(index() / seconds, 0)}
/>
));
)}
</For>
);