Skip to content

feat(fullstack): provide ambient types through plugin import#1286

Merged
hi-ogawa merged 2 commits intomainfrom
10-16-feat_fullstack_provide_ambient_types_through_plugin_import
Oct 16, 2025
Merged

feat(fullstack): provide ambient types through plugin import#1286
hi-ogawa merged 2 commits intomainfrom
10-16-feat_fullstack_provide_ambient_types_through_plugin_import

Conversation

@hi-ogawa
Copy link
Copy Markdown
Owner

@hi-ogawa hi-ogawa commented Oct 16, 2025

We can inject its own vite-plugin-fullstack/types inside vite-plugin-fullstack. This also reduce the need of accessing vite-plugin-fullstack/types for many cases.

This would help when internalizing entire plugin inside Nitro


Hmm, it doesn't look like this is actually helping for Nitro.

Copy link
Copy Markdown
Owner Author

hi-ogawa commented Oct 16, 2025

@hi-ogawa hi-ogawa force-pushed the 10-16-feat_fullstack_provide_ambient_types_through_plugin_import branch from f737815 to 84fcec2 Compare October 16, 2025 13:48
@hi-ogawa hi-ogawa marked this pull request as ready for review October 16, 2025 13:52
@hi-ogawa hi-ogawa force-pushed the 10-16-feat_fullstack_provide_ambient_types_through_plugin_import branch from dec41c2 to 767cbbe Compare October 16, 2025 13:52
Copy link
Copy Markdown
Owner Author

hi-ogawa commented Oct 16, 2025

Merge activity

  • Oct 16, 2:34 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 16, 2:36 PM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 16, 2:37 PM UTC: @hi-ogawa merged this pull request with Graphite.

@hi-ogawa hi-ogawa changed the base branch from 10-16-feat_fullstack_expose_assets.merge_method to graphite-base/1286 October 16, 2025 14:35
@hi-ogawa hi-ogawa changed the base branch from graphite-base/1286 to main October 16, 2025 14:35
@hi-ogawa hi-ogawa force-pushed the 10-16-feat_fullstack_provide_ambient_types_through_plugin_import branch from 767cbbe to 071002b Compare October 16, 2025 14:35
@hi-ogawa hi-ogawa merged commit 7ee1c08 into main Oct 16, 2025
4 checks passed
@hi-ogawa hi-ogawa deleted the 10-16-feat_fullstack_provide_ambient_types_through_plugin_import branch October 16, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant