fix error handling for errors where no message property#24
Open
sargonpiraev wants to merge 1 commit intohharnisc:masterfrom
sargonpiraev:master
Open
fix error handling for errors where no message property#24sargonpiraev wants to merge 1 commit intohharnisc:masterfrom sargonpiraev:master
sargonpiraev wants to merge 1 commit intohharnisc:masterfrom
sargonpiraev:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have discovered that in some cases error object has no message property. For example when target url is invalid and error code is 1006. I found here https://developer.mozilla.org/en-US/docs/Web/API/WebSockets_API/Writing_WebSocket_client_applications#Connection_errors
http://stackoverflow.com/questions/19304157/getting-the-reason-why-websockets-closed - here is explanation what 1006 mean.
So when error.message is undefined we get error argument in connect callback as undefined too. this is incorrect because we cant know if this error happened.