(feat) adds promisified constructor, fixes #10 and #11, bumps minor version#12
Open
sunny-g wants to merge 1 commit intohharnisc:minimongo-cachefrom
Open
(feat) adds promisified constructor, fixes #10 and #11, bumps minor version#12sunny-g wants to merge 1 commit intohharnisc:minimongo-cachefrom
sunny-g wants to merge 1 commit intohharnisc:minimongo-cachefrom
Conversation
|
LGTM |
sunny-g
force-pushed
the
master
branch
2 times, most recently
from
094cb21 to
334db94
Compare
Author
|
Closing because I see why you made the changes (minimongo lets us observe collections rather than directly observing stored data from subscriptions). |
sunny-g
changed the title
sunny-g
force-pushed
the
master
branch
2 times, most recently
from
baeb0b6 to
232cbb8
Compare
Author
|
I've removed the observers since they can't be used, regardless of There may have been a thing or two I've forgotten so let me know if there are any changes you want me to make. |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to #10 and #11, this restores the observer methods
added,changedandremovedto theobserverobject and calls them when handling their corresponding DDP messages.This also fixes a mismatch between the naming convention
changedandupdatedthat wasn't resolved in #11; the observer now has a methodchangedby default that is called when receiving DDP messages of the type "changed".