Added support to not send responses when the handler has already called finish()#108
Open
vivekfantain wants to merge 6 commits intohfaran:masterfrom
Open
Added support to not send responses when the handler has already called finish()#108vivekfantain wants to merge 6 commits intohfaran:masterfrom
vivekfantain wants to merge 6 commits intohfaran:masterfrom
Conversation
…y called finished(). This is useful for HTTP 304 implementation
Owner
|
Hmm, not sure if the test failures here are related to your change; maybe a breaking change in jsonschema. I'll take a look. |
Owner
|
@vivekfantain I just pushed #111 which pins some dependencies to fix the failing tests. Can you merge from the latest upstream master? That should fix it. |
Author
|
Now I have a new issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a bug that caused Tornado to fail because we are sending message after calling finished(). I had submitted an earlier patch that didn't pass tests. This version should. Hopefully!