test(benchmark): skip checking completion time in hot processing#3993
Merged
SukkaW merged 1 commit intohexojs:masterfrom Dec 20, 2019
Merged
test(benchmark): skip checking completion time in hot processing#3993SukkaW merged 1 commit intohexojs:masterfrom
SukkaW merged 1 commit intohexojs:masterfrom
Conversation
2 tasks
0b5871c to
6a18016
Compare
6a18016 to
88506bc
Compare
SukkaW
approved these changes
Dec 20, 2019
Member
|
We should focus on improving performance for bigger sites. |
Member
|
@dailyrandomphoto As you can see in #3941 & #3812, performance regression is already noticeable enough. |
Member
|
Ok, I see. |
thom4parisot
pushed a commit
to thom4parisot/hexo
that referenced
this pull request
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
After #3991, the CI on master branch is failing because the hot processing takes less than 10 seconds.
This PR skips completion time and line number checking in hot processing.
How to test
Pull request tasks