Clean up behavior when no comment provider specified.#52
Open
emceeaich wants to merge 6 commits intohexojs:masterfrom
Open
Clean up behavior when no comment provider specified.#52emceeaich wants to merge 6 commits intohexojs:masterfrom
emceeaich wants to merge 6 commits intohexojs:masterfrom
Conversation
…if comments are turned off or not enabled.
Author
|
Pinging the project maintainers, is this theme still being supported? |
Contributor
|
Supported by society. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a site does not specify either a disqus or Facebook comment provider, individual posts are still rendered with an empty comment box. This is fixed in this pull request.
A site that specified 'en' as language would still use the 'tw' language local files. Add a
en.ymllocale file.Update documentation in the readme.
In the longer term it would be good to get per-site configurations out of the theme and moved into to
site/_config.yml