Skip to content

Fix password validation to require letter or number #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix password validation to require letter or number #2311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/codebattle/assets/js/__fixtures__/signUpData.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@
"Should be from 6 to 16 characters",
"password"
],
[
"password validation: only special characters",
"!@#$%&*?",
"Should contain at least one letter or number",
"password"
],
[
"password validation: long password",
"11111111111111111",
Expand Down
1 change: 1 addition & 0 deletions apps/codebattle/assets/js/widgets/formik/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ const schemas = {
.matches(/^\S*$/, "Can't contain empty symbols")
.min(6, "Should be from 6 to 16 characters")
.max(16, "Should be from 6 to 16 characters")
.matches(/[a-zA-Z0-9]/, "Should contain at least one letter or number")
.matches(/[!@#$%^&*(),.?":{}|<>]/, "Should contain at least one special character")
.required("Password required"),
passwordConfirmation: Yup.string()
Expand Down