fix: resolve stale member stats and null addresses (#59, #60)#5
Open
hexdaemon wants to merge 8 commits intohexdaemon:mainfrom
Open
fix: resolve stale member stats and null addresses (#59, #60)#5hexdaemon wants to merge 8 commits intohexdaemon:mainfrom
hexdaemon wants to merge 8 commits intohexdaemon:mainfrom
Conversation
…mpotency Protocol hardening: version tolerance + deterministic idempotency
…mpotency Protocol hardening: Phases B+C+D (version tolerance, idempotency, reliable delivery)
…on-idempotency Hardening: Phase B/C protocol versioning, idempotency & bug fixes
Added an image to enhance the article's visual appeal.
…on-idempotency Comprehensive hardening: P0/P1 bug fixes, thread safety, security
…on-idempotency fix: P2/P3 hardening across 13 modules
contribution_ratio was never synced from the ledger to hive_members, last_seen only updated on connect/disconnect events, and addresses were never captured at join time. This fixes all three root causes plus initializes presence tracking at join so uptime_pct accumulates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The hive-status RPC only returned tier/joined_at/pubkey for our membership, so cl-revenue-ops revenue-hive-status showed null for these fields (Issue #36). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contribution_rationow dynamically calculated from ledger (was always 0.0),uptime_pctformatted as 0-100%,last_seenupdates on any Hive message (not just connect/disconnect), presence tracking initialized at joinlistpeersat join time and backfilled on peer connect if missingChanges
modules/rpc_commands.py: Enrichmembers()RPC with live contribution_ratio and formatted uptime_pctcl-hive.py: Sync contribution_ratio in maintenance loop, update last_seen on all Hive messages, capture addresses at join and on connect, initialize presence at jointests/test_issue_59_60.py: 11 new tests covering all fixesTest plan
python3 -m pytest tests/test_issue_59_60.py -v— 11/11 passpython3 -m pytest tests/ -v— 1137/1137 pass (3 pre-existing asyncio failures unrelated)Closes lightning-goats#59
Closes lightning-goats#60
🤖 Generated with Claude Code