fix pure asm file (with .s extension) compilation#84
Merged
hexdae merged 1 commit intohexdae:masterfrom Oct 19, 2025
Merged
Conversation
Owner
|
Perfect, want to drop the first commit and we merge? |
danielfu11
force-pushed
the
dfu/fix-pure-asm-file-compilation
branch
from
a47360a to
c97d49e
Compare
Contributor
Author
|
Dropped, thanks for the quick review! |
Contributor
Author
|
@hexdae Gentle bump on approval, when you get a chance |
hexdae
approved these changes
Oct 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #78
4295ffc shows that the issue can reproduced easily
a47360a has the fix that gets the example to build successfully
After @hexdae takes an initial look, I can drop the first commit