Skip to content

Conversation

@phm07
Copy link
Contributor

@phm07 phm07 commented Jan 15, 2026

This PR adds the following package files to releases:

  • hcloud-cli-1.59.0-1.aarch64.rpm
  • hcloud-cli-1.59.0-1.x86_64.rpm
  • hcloud-cli_1.59.0_amd64.deb
  • hcloud-cli_1.59.0_arm64.deb

@phm07 phm07 self-assigned this Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.29%. Comparing base (92f34fb) to head (097f2f0).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
- Coverage   72.49%   72.29%   -0.21%     
==========================================
  Files         302      302              
  Lines       11007    11015       +8     
==========================================
- Hits         7980     7963      -17     
- Misses       2152     2165      +13     
- Partials      875      887      +12     
Flag Coverage Δ
e2e 51.43% <ø> (-0.30%) ⬇️
unit 67.29% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07
Copy link
Contributor Author

phm07 commented Jan 16, 2026

Some considerations:

  • Right now goreleaser generates a lot of package files, because it generates one for each architecture. We might want to limit those, amd64 and arm64 would probably be enough. (We still offer direct binary downloads for all architectures anyway)
  • Packages are not signed yet. This causes a problem on alpine for example: ERROR: hcloud-cli_1.59.0_x86_64.apk: UNTRUSTED signature. We'd need to create a key and provide it to users so they can install it

@phm07 phm07 marked this pull request as ready for review January 22, 2026 09:14
@phm07 phm07 requested a review from a team as a code owner January 22, 2026 09:14
@phm07 phm07 force-pushed the build-linux-packages branch from 5f9b15c to be4a77e Compare January 22, 2026 13:07
@phm07 phm07 changed the title feat: build .deb, .rpm and .apk release files feat: build .deb and .rpm release files Jan 22, 2026
s, _ := state.New(config.New())
rootCommand := cli.NewRootCommand(s)

err := doc.GenManTree(rootCommand, nil, "./manpages")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The man pages have a 23-Jan-2026 Auto generated by spf13/cobra comment included. Is it possible to remove them, similar to how we are doing it for the markdown files?

// Remove the 'Auto generated by...' lines at the bottom of files
// This is done because this line contains the current date, which would create a diff when the file is re-generated
generatedOnRegex := regexp.MustCompile(`\n###### Auto generated by spf13/cobra on .*\n`)
for _, f := range files {
if f.IsDir() {
continue
}
path := filepath.Join(dir, f.Name())
bytes, err := os.ReadFile(path)
if err != nil {
return fmt.Errorf("could not read file at %q: %w", path, err)
}
bytes = generatedOnRegex.ReplaceAll(bytes, nil)
// We do this to wrap tables in a code block. Otherwise, they won't be displayed properly in markdown viewers.
bytes = []byte(strings.ReplaceAll(string(bytes), "┌", "```\n┌"))
bytes = []byte(strings.ReplaceAll(string(bytes), "┘", "┘\n```"))
err = os.WriteFile(path, bytes, f.Type())
if err != nil {
return fmt.Errorf("could not write file at %q: %w", path, err)
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, could you have a look at the table output in man hcloud-config? It is pretty wonky right now.

@phm07
Copy link
Contributor Author

phm07 commented Jan 23, 2026

The manpage output (as well as the generated markdown docs) would have a way better table view if the tables are printed using markdown format. Our table renderer already supports this, we just need to find a way to switch between the pretty print and markdown. I used a custom config option for now but it doesn't seem to work, because viper is not loaded if you only generate docs/manpages. I'll have a look at this another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants