Open
Conversation
…er processing logic to a separate method
Owner
|
Welcome, Roman! Swipe feature is the very feature that Pointeract lacks, I've been planning to add this feature for a long time. Your implementation and understanding of SynthKernel are solid, I will review deeper and merge this night (4-5 hours later). P.S. About the Angular version you mentioned in your email, I think it is a better choice to make Pointeract a monorepo which contains the Pointeract core and all adaptors (including your Angular one). This can make future development much easier (like how I recently converted my another vanilla TS library into core + adaptors). The conversion will be effortless and done very soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, Hēsperus!
Some library enhancement :)
P.S. I don't have any idea how to add swipe to the playground without extending it with another example ¯_(ツ)_/¯
P.P.S Check your email, I wrote you about Angular library based on Pointeract