This repository was archived by the owner on Feb 24, 2026. It is now read-only.
Open
Conversation
A 301 is permanent and some usages may benefit from something other than that.
phanimahesh
approved these changes
Oct 11, 2018
phanimahesh
left a comment
phanimahesh
left a comment
There was a problem hiding this comment.
LGTM. This would be a nice addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 301 is permanent and some usages may benefit from something other than
that. For example, redirections within a single domain (to a login page) or for some
temporary downtime.
This change is fully backwards compatible. I have not added tests yet for this one since
the change was rather trivial, but I can always add some if you'd like me to.