This repository was archived by the owner on Feb 12, 2022. It is now read-only.
enable Windows users to specify an alternate home directory#810
Open
fastcatch wants to merge 1 commit intoheroku:masterfrom
Open
enable Windows users to specify an alternate home directory#810fastcatch wants to merge 1 commit intoheroku:masterfrom
fastcatch wants to merge 1 commit intoheroku:masterfrom
Conversation
… avoid problems with non-English account names)
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolbelt would not work on Windows if the user has an account name with non-English letters in it (such as Latin-1, etc.); even though this is perfectly valid in Windows.
With this change the user can specify a HEROKU_HOME environment variable to be used as home directory for the toolbelt (which falls back to the standard USERPROFILE). If this directory has only English ASCII characters in it the toolbelt starts to work just fine.