This repository was archived by the owner on Feb 12, 2022. It is now read-only.
require the at option when scheduling backups#1485
Open
neovintage wants to merge 1 commit intomasterfrom
Open
Conversation
Contributor
|
Interesting idea. It seems weird to have required flags (options are usually... optional), but it might make sense here. Are there other instances of this behavior in the CLI? |
Contributor
|
perhaps prompt if no time is scheduled instead of forcing them to run the command again? |
Contributor
Author
|
@uhoh-itsmaciek I quickly grep-ed across codebase and didn't see it being done anywhere else. I wouldn't want to be the first one to start requiring options. @dickeyxxx That's a good idea. |
jdx
force-pushed
the
scheduling-time
branch
2 times, most recently
from
29b9d59 to
1a5ee19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small UX problem whereby someone creates a schedule and then issues the same command without the at flag thinking they could view schedules. The schedule is overwritten and set back to 4:00 UTC.
/cc @uhoh-itsmaciek @chadbailey59
What do you guys think?