This repository was archived by the owner on Feb 12, 2022. It is now read-only.
shebang breaks the executable on systems with {rbenv,rvm}-managed rubies#1211
Open
berdario wants to merge 91 commits intoheroku:masterfrom
Open
shebang breaks the executable on systems with {rbenv,rvm}-managed rubies#1211berdario wants to merge 91 commits intoheroku:masterfrom
berdario wants to merge 91 commits intoheroku:masterfrom
Conversation
Don't update manifest or update hash during beta phase.
upgraded heroku-api and excon
use svg badges for retina displays
test on ruby 2.0.0 and 2.1.2 for future compatibility
Fix beta releases
Better errors when psql fails and when we can't check the pg version
added cove coverage via coveralls/simplecov
Record source app id as fork deploy source
get rid of travis notifications (way too many messages)
upgrade gems (notably excon)
added ocra script
Fixes heroku#1201 RestClient is not available if you use Client directly without CLI/
require rest-client in Client
Paranoid currently only works in Excon. This adds support to `RestClient` as well.
…id-support Support for paranoid operations on commands using `RestClient`
prompt for creating ~/.ssh/id_rsa
This lets users kill all their existing connections even when they have no remaining connections on their given database plan, preventing a chicken-and-egg problem in some situations.
…llall Use server-side connection reset endpoint for pg:killall
As part of the eventual deprecation of the Manager API component, the main API will now start to respond to fulfill orgs-related requests. See also heroku/api#2837.
Send all orgs-related requests to api.heroku.com
berdario
added a commit
to berdario/dotfiles
that referenced
this pull request
Sep 29, 2014
This reverts commit 37fadd9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically the same issue mentioned in this comment
Using
envin the shebang is all fine and dandy as long as you have a standalone script that can run on different ruby versions, but as soon as you add some dependencies (like in heroku's case) you cannot expect that the interpreter in the current environment has them installed. I stumbled upon this issue after installing the heroku toolbelt from its deb repositories on a normal ubuntu system with multiple rubies managed byrbenv. So the scripts should rely on the same ruby interpreter that has been required as a dependency by the debian package, not the one resolved byenv(granted, rather than merging this you might want to tweak
deb.raketo take care of possible differences in the location of therubyexecutable on different distros)An example of another application that avoids
envin its executable's shebang isdropbox, and indeed the dropbox script works just fine even when invoked from inside a virtualenv (which is sort of the python equivalent of rbenv, rvm)