Refactor WmmEncoder and add ActiveSetAnalysis class#980
Open
ThomasHaas wants to merge 16 commits intodevelopmentfrom
Open
Refactor WmmEncoder and add ActiveSetAnalysis class#980ThomasHaas wants to merge 16 commits intodevelopmentfrom
ThomasHaas wants to merge 16 commits intodevelopmentfrom
Conversation
- PropertyEncoder now takes a WmmEncoder as parameter to encode Wmm-related properties
- Minor cleanup in WmmEncoder
ThomasHaas
changed the title
- Removed all encoding code from Definition.java
Move idl2Sat option to WmmEncoder Move EncodingContext.memoryOrderClock to WmmEncoder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActiveSetAnalysisto compute active sets (encode sets). It contains the previousEncodeSetandLazyEncodeSetclassesWmmEncoder: Axioms don't encode themselves anymoreActiveSetAnalysis: Axioms don't compute their own active sets anymoreEDIT: I think there is still more refactoring that can be done, but for now it should be in a good shape (a lot better than before!!!).