Skip to content

Update Ptx constant-proxy rule#531

Merged
hernanponcedeleon merged 7 commits intohernanponcedeleon:developmentfrom
tonghaining:ptx-constant
Oct 22, 2023
Merged

Update Ptx constant-proxy rule#531
hernanponcedeleon merged 7 commits intohernanponcedeleon:developmentfrom
tonghaining:ptx-constant

Conversation

@tonghaining
Copy link
Contributor

This PR contains 2 updates:

  1. As verified in PTX document, weak instructions don't hold the scope tag. It is removed from the visitors now.
  2. We found the addition of the constant-proxy rule will no longer be necessary following the modification that explicitly defines locations as Constant virtually aliasing to Generic locations. There is a corresponding pull request toward the original PTX alloy approach. We could await confirmation on whether it is appropriate to proceed with this change.

@hernanponcedeleon
Copy link
Owner

There has not been any answer regarding the PR to the repository with the alloy model. However, the model in this PR is more faithful to their model, so I will merge.

@hernanponcedeleon hernanponcedeleon merged commit 469233c into hernanponcedeleon:development Oct 22, 2023
@tonghaining tonghaining deleted the ptx-constant branch January 5, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants